Adding tests to and refactoring the perl debugger - Grant Report #4

Shlomi Fish reported:

2012-Sep-25:

• Test o inhibit_exit.

2012-Sep-28:

• Add some tests for o PrintRet.

  • Commit: 81de4a156bc803cb68a711f9ef9de78c75b86c20

2012-Sep-30:

• Yesterday and today I started refactoring lib/perl5db.pl. I'm glad to say that the test suite caught some bugs introduced by refactoring.

  • Commit: 85b0ebc0aba46f02639bd872967061727fa43b06

• Filed an rt.perl.org bug with patches:

  • https://rt.perl.org/rt3/Ticket/Display.html?id=115084

2012-Oct-04:

• Did more refactoring to the perl debugger.

• Fixed a [command] without a line number:

  • https://rt.perl.org/rt3/Ticket/Display.html?id=115110

  • Commit: 24a3c3702109c5e7485eb6cab7d581199c9888cd

2012-Oct-05:

• More refactoring - leading ampersands and method extractions.

2012-Oct-06:

• More refactoring - extracted methods and subroutines.

2012-Oct-07:

• More refactoring - extracted some methods.

2012-Oct-08:

• More refactoring - extracted some methods.

  • Commit: 9cf9b5691a042f1dae312f4261014046a162b19d

2012-Oct-14:

• More refactoring - created a dispatch table for commands based on their initial command field.

  • Commit: 33b79f21d69af2c650bcb41cb4a6219659447813

2012-Oct-15:

• More refactoring - finished most of the dispatching based on the table.

• More refactoring - split the command into a verb and args and start inspecting cmd_args directly.

• More refactoring - made some variable lexicals instead of slots in the objects - apparently they were just overused for some purposes.

2012-Oct-16:

• Refactoring - finish converting to cmd_verb and cmd_args.

• Posted this post to the perl5-porters mailing list:

  • http://www.nntp.perl.org/group/perl.perl5.porters/2012/10/msg194165.html

2012-Oct-17:

• Got rid of leading ampersands in sub calls (except for the &share).

• Made sure that we don't use DB::warn() and DB::system() which clash with perl built-in functions.